forks
/
D-Scanner
mirror of https://github.com/dlang-community/D-Scanner.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Autofix for DeleteCheck (#144)

This commit is contained in:
Vladiwostok 2024-10-03 10:57:57 +03:00 committed by Albert24GG
parent e52e2970f9
commit cec745a2e1
1 changed files with 36 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
src/dscanner/analysis/del.d
View File

@ -15,10 +15,12 @@ import dsymbol.scope_;
*/ */
extern(C++) class DeleteCheck(AST) : BaseAnalyzerDmd extern(C++) class DeleteCheck(AST) : BaseAnalyzerDmd
{ {
// alias visit = BaseAnalyzerDmd!AST.visit;
alias visit = BaseAnalyzerDmd.visit; alias visit = BaseAnalyzerDmd.visit;
mixin AnalyzerInfo!"delete_check"; mixin AnalyzerInfo!"delete_check";
private enum KEY = "dscanner.deprecated.delete_keyword";
private enum MSG = "Avoid using the 'delete' keyword.";
extern(D) this(string fileName) extern(D) this(string fileName)
{ {
super(fileName); super(fileName);
@ -26,8 +28,17 @@ extern(C++) class DeleteCheck(AST) : BaseAnalyzerDmd
override void visit(AST.DeleteExp d) override void visit(AST.DeleteExp d)
{ {
addErrorMessage(cast(ulong) d.loc.linnum, cast(ulong) d.loc.charnum, "dscanner.deprecated.delete_keyword", import dmd.hdrgen : toChars;
"Avoid using the 'delete' keyword."); import std.conv : to;
string exprStr = to!string(toChars(d));
addErrorMessage(
cast(ulong) d.loc.linnum, cast(ulong) d.loc.charnum, KEY, MSG,
[AutoFix.replacement(d.loc.fileOffset, d.loc.fileOffset + 6, `destroy(`, "Replace delete with destroy()")
.concat(AutoFix.insertionAt(d.loc.fileOffset + exprStr.length, ")"))]
);
super.visit(d); super.visit(d);
} }
} }
@ -35,10 +46,11 @@ extern(C++) class DeleteCheck(AST) : BaseAnalyzerDmd
unittest unittest
{ {
import dscanner.analysis.config : StaticAnalysisConfig, Check, disabledConfig; import dscanner.analysis.config : StaticAnalysisConfig, Check, disabledConfig;
import dscanner.analysis.helpers : assertAnalyzerWarnings; import dscanner.analysis.helpers : assertAnalyzerWarnings, assertAutoFix;
StaticAnalysisConfig sac = disabledConfig(); StaticAnalysisConfig sac = disabledConfig();
sac.delete_check = Check.enabled; sac.delete_check = Check.enabled;
assertAnalyzerWarningsDMD(q{ assertAnalyzerWarningsDMD(q{
void testDelete() void testDelete()
{ {
@ -50,5 +62,25 @@ unittest
} }
}c, sac); }c, sac);
assertAutoFix(q{
void testDelete()
{
int[int] data = [1 : 2];
delete data[1]; // fix
auto a = new Class();
delete a; // fix
}
}c, q{
void testDelete()
{
int[int] data = [1 : 2];
destroy(data[1]); // fix
auto a = new Class();
destroy(a); // fix
}
}c, sac, true);
stderr.writeln("Unittest for DeleteCheck passed."); stderr.writeln("Unittest for DeleteCheck passed.");
} }