From 2ff1291b09d4804a12b8f2f0522ae0c40a02dea5 Mon Sep 17 00:00:00 2001
From: WebFreak001 <gh@webfreak.org>
Date: Wed, 22 Mar 2023 02:35:40 +0100
Subject: [PATCH] properly wait for server shutdown in CI

---
 tests/run_tests.sh | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/tests/run_tests.sh b/tests/run_tests.sh
index 5a30576..3bcf7fe 100755
--- a/tests/run_tests.sh
+++ b/tests/run_tests.sh
@@ -44,6 +44,7 @@ pass_count=0
 client="../bin/dcd-client"
 server="../bin/dcd-server"
 tcp=""
+server_pid=""
 
 function startServer()
 {
@@ -57,6 +58,24 @@ function startServer()
 	sleep 1
 }
 
+function waitShutdown()
+{
+	if [[ -z "$server_pid" ]]; then
+		sleep 0.5 # not owned by us
+	else
+		( sleep 15 ; echo 'Waiting for shutdown timed out'; kill $server_pid ) &
+		killerPid=$!
+
+		wait $server_pid
+		status=$?
+		(kill -0 $killerPid && kill $killerPid) || true
+
+		server_pid=""
+
+		return $status
+	fi
+}
+
 # Make sure that the server is shut down
 echo "Shutting down currently-running server..."
 "$client" --shutdown 2>/dev/null > /dev/null
@@ -64,7 +83,7 @@ echo "Shutting down currently-running server..."
 
 for socket in $SOCKETMODES; do # supported: unix tcp
 	# allow some time for server to shutdown
-	sleep 0.5;
+	waitShutdown
 
 	if [[ $socket == "tcp" ]]; then
 		tcp="--tcp"
@@ -119,6 +138,8 @@ for socket in $SOCKETMODES; do # supported: unix tcp
 	echo "Shutting down server..."
 	"$client" --shutdown "$tcp" 2>/dev/null > /dev/null
 
+	waitShutdown
+
 	# Report
 	if [[ $fail_count -eq 0 ]]; then
 		echo -e "${GREEN}${pass_count} tests passed and ${fail_count} failed.${NORMAL}"