forks
/
DCD
mirror of https://github.com/dlang-community/DCD.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge 5b95f7187f into 1498ef1c1c

This commit is contained in:
bangbangsheshotmedown 2025-10-18 23:47:00 +02:00 committed by GitHub
parent 1498ef1c1c 5b95f7187f
commit bfe2238126
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/dcd/server/autocomplete/complete.d
View File

@ -592,7 +592,16 @@ void setCompletions(T)(ref AutocompleteResponse response,
{ {
if (sym.name !is null && sym.name.length > 0 && isPublicCompletionKind(sym.kind) if (sym.name !is null && sym.name.length > 0 && isPublicCompletionKind(sym.kind)
&& (p is null ? true : toUpper(sym.name.data).startsWith(toUpper(p))) && (p is null ? true : toUpper(sym.name.data).startsWith(toUpper(p)))
&& !r.completions.canFind!(a => a.identifier == sym.name) && !r.completions.canFind!((a) {
// this filters out similar symbols
// fast check first, only compare full definition if it matches
bool same = a.identifier == sym.name && a.kind == sym.kind;
if (same) {
auto info = makeSymbolCompletionInfo(sym, sym.kind);
if (info.definition != a.definition) same = false;
}
return same;
})
&& sym.name[0] != '*' && sym.name[0] != '*'
&& mightBeRelevantInCompletionScope(sym, completionScope)) && mightBeRelevantInCompletionScope(sym, completionScope))
{ {
@ -610,6 +619,16 @@ void setCompletions(T)(ref AutocompleteResponse response,
auto currentSymbols = completionScope.getSymbolsInCursorScope(cursorPosition); auto currentSymbols = completionScope.getSymbolsInCursorScope(cursorPosition);
foreach (s; currentSymbols.filter!(a => isPublicCompletionKind(a.kind) foreach (s; currentSymbols.filter!(a => isPublicCompletionKind(a.kind)
&& toUpper(a.name.data).startsWith(toUpper(partial)) && toUpper(a.name.data).startsWith(toUpper(partial))
&& !response.completions.canFind!((r) {
// this filters out similar symbols
// fast check first, only compare full definition if it matches
bool same = (r.identifier == a.name && r.kind == a.kind);
if (same) {
auto info = makeSymbolCompletionInfo(a, a.kind);
if (info.definition != r.definition) same = false;
}
return same;
})
&& mightBeRelevantInCompletionScope(a, completionScope))) && mightBeRelevantInCompletionScope(a, completionScope)))
{ {
response.completions ~= makeSymbolCompletionInfo(s, s.kind); response.completions ~= makeSymbolCompletionInfo(s, s.kind);