From 767aa4bdbefbbd725e791a2c1462f1f7a5a871cd Mon Sep 17 00:00:00 2001 From: and3md Date: Tue, 21 Mar 2017 18:12:42 +0100 Subject: [PATCH 1/3] Fixed double item selection on combo list when changing selected item from code. --- src/dlangui/widgets/combobox.d | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/dlangui/widgets/combobox.d b/src/dlangui/widgets/combobox.d index c9458ab8..780800ad 100644 --- a/src/dlangui/widgets/combobox.d +++ b/src/dlangui/widgets/combobox.d @@ -68,6 +68,9 @@ class ComboBoxBase : HorizontalLayout, OnClickHandler { @property ComboBoxBase selectedItemIndex(int index) { if (_selectedItemIndex == index) return this; + if (_selectedItemIndex != -1) { + _adapter.resetItemState(_selectedItemIndex, State.Selected | State.Focused | State.Hovered); + } _selectedItemIndex = index; if (itemClick.assigned) itemClick(this, index); From 3bb823901f241fb6c769270c3792279b90da758e Mon Sep 17 00:00:00 2001 From: and3md Date: Tue, 21 Mar 2017 19:09:01 +0100 Subject: [PATCH 2/3] Uncomented requestLayout() in scrollbar fix scrollbox sliders update issues Possible fix #192. --- src/dlangui/widgets/scrollbar.d | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dlangui/widgets/scrollbar.d b/src/dlangui/widgets/scrollbar.d index 5122f103..dbb24647 100644 --- a/src/dlangui/widgets/scrollbar.d +++ b/src/dlangui/widgets/scrollbar.d @@ -84,7 +84,7 @@ class AbstractSlider : WidgetGroup { @property AbstractSlider pageSize(int size) { if (_pageSize != size) { _pageSize = size; - //requestLayout(); + requestLayout(); } return this; } @@ -107,7 +107,7 @@ class AbstractSlider : WidgetGroup { if (_minValue != min || _maxValue != max) { _minValue = min; _maxValue = max; - //requestLayout(); + requestLayout(); } return this; } From e68496897eed1c511f60ce20d97fab58f44b2564 Mon Sep 17 00:00:00 2001 From: and3md Date: Thu, 23 Mar 2017 18:01:42 +0100 Subject: [PATCH 3/3] Reverted accidentally commit "Uncomented requestLayout() in scrollbar fix scrollbox sliders update issues" from this branch --- src/dlangui/widgets/scrollbar.d | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dlangui/widgets/scrollbar.d b/src/dlangui/widgets/scrollbar.d index dbb24647..5122f103 100644 --- a/src/dlangui/widgets/scrollbar.d +++ b/src/dlangui/widgets/scrollbar.d @@ -84,7 +84,7 @@ class AbstractSlider : WidgetGroup { @property AbstractSlider pageSize(int size) { if (_pageSize != size) { _pageSize = size; - requestLayout(); + //requestLayout(); } return this; } @@ -107,7 +107,7 @@ class AbstractSlider : WidgetGroup { if (_minValue != min || _maxValue != max) { _minValue = min; _maxValue = max; - requestLayout(); + //requestLayout(); } return this; }